Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

From: punit vara
Date: Wed Oct 21 2015 - 14:05:14 EST


On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> On 10/21/2015, 04:55 PM, Punit Vara wrote:
>> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
>> static int at76_remap(struct usb_device *udev)
>> {
>> int ret;
>> - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
>> + return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
>> USB_TYPE_VENDOR | USB_DIR_OUT |
>> USB_RECIP_INTERFACE, 0, 0, NULL, 0,
>> USB_CTRL_GET_TIMEOUT);
>> - if (ret < 0)
>> - return ret;
>> - return 0;
>
> ret is now unused, right?
>
> --
> js
> suse labs
Oppp..Sorry I have missed int ret to remove . I will resend the
updated patch soon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/