Re: [RFC][PATCH] tracing: Have stack tracer force RCU to be watching

From: Steven Rostedt
Date: Wed Oct 21 2015 - 07:39:31 EST


On Wed, 21 Oct 2015 10:01:42 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > I should probably add a "if (in_nmi()) return" somewhere.
>
> But if there's an arch that doesn't use a separate NMI stack, the NMI
> might cause the largest stack, which would then remain invisible from
> the stack-tracer.
>
> Should we not instead fix the NMI-safety of this tracer?

We could, but that should be a separate project, as that would require
doing everything lockless, which would require a redesign. Is that
worth it?

For now, the safe thing to do is the if (in_nmi()), but certainly, if
someone gets time to make it NMI safe, we can do that too.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/