Re: [PATCH 3.4 17/65] fixing infinite OPEN loop in 4.0 stateid recovery

[Zefan Li]

On 2015/10/20 21:25, Kornievskaia, Olga wrote:
> That patch introduced a different problem that was fixed by commit a41cbe86df3afbc82311a1640e20858c0cd7e065

I'll queue it up for 3.4.y. Thanks!

> (NFS4CLNT_RECLAIM_NOGRACE was suppose to be NFS_STATE_RECLAIM_NOGRACE)
>
> Re: Failing to send a CLOSE if file is opened WRONLY and ... <https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB0QFjAAahUKEwjEj9bLktHIAhXMpx4KHZVDC6o&url=http://www.spinics.net/lists/linux-nfs/msg53705.html&usg=AFQjCNEIHLOoLJV6YmJh0G_O5Jj9OcrS8g&sig2=Y76g-bzz-2SLr9OF5xNjvw&bvm=bv.105454873,d.cWw>
>
>
> > On Oct 19, 2015, at 8:47 PM, lizf@xxxxxxxxxx <mailto:lizf@xxxxxxxxxx> wrote:
> >
> > From: Olga Kornievskaia <kolga@xxxxxxxxxx <mailto:kolga@xxxxxxxxxx>>
> >
> > 3.4.110-rc1 review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> >
> > commit e8d975e73e5fa05f983fbf2723120edcf68e0b38 upstream.
> >
> > Problem: When an operation like WRITE receives a BAD_STATEID, even though
> > recovery code clears the RECLAIM_NOGRACE recovery flag before recovering
> > the open state, because of clearing delegation state for the associated
> > inode, nfs_inode_find_state_and_recover() gets called and it makes the
> > same state with RECLAIM_NOGRACE flag again. As a results, when we restart
> > looking over the open states, we end up in the infinite loop instead of
> > breaking out in the next test of state flags.
> >
> > Solution: unset the RECLAIM_NOGRACE set because of
> > calling of nfs_inode_find_state_and_recover() after returning from calling
> > recover_open() function.
> >
> > Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx <mailto:kolga@xxxxxxxxxx>>
> > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx <mailto:trond.myklebust@xxxxxxxxxxxxxxx>>
> > [lizf: Backported to 3.4: adjust context]
> > Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx <mailto:lizefan@xxxxxxxxxx>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/