Re: [PATCH 13/16] perf callchain: Switch default to 'graph,0.5,caller'

From: Namhyung Kim
Date: Wed Oct 21 2015 - 03:29:16 EST


Hi Brendan,

On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote:
> On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote:
> >> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >>
> >> Which is the most common default found in other similar tools.
> >
> > I think it's more useful to change the default only when --children is
> > used. And there's a related issue too - please see below link:
> >
> > https://lkml.org/lkml/2014/8/14/49
>
> --children is default for things like "perf report --stdio" and
> (implied) "perf script", so any change to --children is a change to
> default.

Hmm.. right. It should change the default only when --children is
actually used in "perf report" or "perf top" so that "perf script" or
other commands should not be changed.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/