Re: [PATCH v1 2/2] ARM: dts: rockchip: Add the OTP gpio pinctrl

From: Doug Anderson
Date: Wed Oct 21 2015 - 00:25:48 EST


Caesar,

On Tue, Oct 20, 2015 at 7:43 PM, Caesar Wang <wxt@xxxxxxxxxxxxxx> wrote:
> We need the OTP pin is gpio state before resetting the TSADC controller,
> since the tshut polarity will generate a high signal.

It might or might not be "high" depending on polarity, right? It's
just possible that it could glitch during probe. Other than that nit,
this seems fine to me.

If it's not too much trouble it'd be nice if you could spin with the
description change. Otherwise:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/