Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()

From: Sagi Grimberg
Date: Tue Oct 20 2015 - 07:41:50 EST


On 10/19/2015 11:18 PM, Luis de Bethencourt wrote:
Smatch complains about returning hard coded error codes, silence this
warning.

drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/