Re: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str'

From: Ingo Molnar
Date: Tue Oct 20 2015 - 03:36:12 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Mon, Oct 19, 2015 at 05:20:03PM -0200, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Oct 19, 2015 at 09:09:32PM +0200, Ingo Molnar escreveu:
> > > * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > > Em Mon, Oct 19, 2015 at 04:54:47PM -0200, Arnaldo Carvalho de Melo escreveu:
> > > > > Em Mon, Oct 19, 2015 at 07:34:46AM -0600, David Ahern escreveu:
> > > > > > Seems like 'R' is more appropriate here.
>
> > > > > Right, changed it.
>
> > > > And then, he does that on a later patch, duh.
>
> > > Yeah, indeed - I messed that up: tried to introduce __unused but noticed during
> > > development and testing on other distros that '__unused' is way too crowded a
> > > namespace (various fields in random headers are named like that), so after a bit
> > > of a fight with those headers I changed it back to __maybe_unused ... but the
> > > original change slipped into the series.
> > >
> > > Do you want me to resend the series to fix this and the other problems David and
> > > you noticed?
> >
> > No problem, I fixed it all already :-)
>
> Please check my perf/core branch.

Looks good - thanks Arnaldo!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/