Re: [PATCH] devfreq: correctly check failed allocation

[MyungJoo Ham]

>Since devm_kzalloc can be failed in memory pressure,
>check return value and handle error.
>
>Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx>
>---
> drivers/devfreq/devfreq.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>index ca1b362..814089f 100644
>--- a/drivers/devfreq/devfreq.c
>+++ b/drivers/devfreq/devfreq.c
>@@ -482,9 +482,23 @@ struct devfreq *devfreq_add_device(struct device *dev,
> 						devfreq->profile->max_state *
> 						devfreq->profile->max_state,
> 						GFP_KERNEL);
>+	if (!devfreq->trans_table) {
>+		dev_err(dev, "%s: Unable to create transition table for the device\n",
>+			__func__);
>+		err = -ENOMEM;
>+		goto err_dev;
>+	}
>+

I don't see a label 'err_dev' in devfreq.c
And please note that you are under a mutex lock here as well; you must unlock it before returning.


For devfreq.c of most recent release candidate, please refer to 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/devfreq/devfreq.c?id=7379047d5585187d1288486d4627873170d0005a

You don't seem to be based on a recent RC as well.

Cheers,
MyungJoo

N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå