Re: [PATCH 4.2 022/258] toshiba_acpi: Fix hotkeys registration on some toshiba models

[Ben Hutchings]

On Sat, 2015-10-17 at 18:55 -0700, Greg Kroah-Hartman wrote:
> 4.2-stable review patch.ÂÂIf anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Azael Avalos <coproscefalo@xxxxxxxxx>
> 
> commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream.
> 
> Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
> for keymap choosing") changed the *setup_keyboard function to query for
> the Hotkey Event Type to help choose the correct keymap, but turns out
> that here are certain Toshiba models out there not implementing this
> feature, and thus, failing to continue the input device registration and
> leaving such laptops without hotkey support.
> 
> This patch changes such check, and instead of returning an error if
> the Hotkey Event Type is not present, we simply inform userspace about it,
> changing the message printed from err to notice, making the function
> responsible for registering the input device to continue.
[...]

But then this function proceeds without events_type being initialised
at all, with unpredictable results. ÂThis doesn't look like a proper
 fix.

Ben.

-- 
Ben Hutchings
The first rule of tautology club is the first rule of tautology club.

Attachment: signature.asc
Description: This is a digitally signed message part