Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency

From: Laurent Pinchart
Date: Mon Oct 19 2015 - 02:41:59 EST


Hi Magnus,

Thank you for the patch.

On Monday 19 October 2015 12:02:53 Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>
> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE
> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get
> rid of the dependency.
>
> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using:
> # CONFIG_ARM_LPAE is not set

The driver only supports the 40-bits page table format for now, hence the
dependency on LPAE, but it indeed seems that the dependency is bogus. As long
as the 8 MSBs of the translated address are all 0 I assume the output 40-bit
address is usable on a 32-bit physical address system.

How have you tested the patch ?

> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
> ---
>
> drivers/iommu/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- 0001/drivers/iommu/Kconfig
> +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900
> @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE
>
> config IPMMU_VMSA
> bool "Renesas VMSA-compatible IPMMU"
> - depends on ARM_LPAE
> depends on ARCH_SHMOBILE || COMPILE_TEST
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/