[PATCH 0/5] drivers/tty: make more bool drivers explicitly non-modular

From: Paul Gortmaker
Date: Sun Oct 18 2015 - 18:22:29 EST


This next set of patches to drivers/tty fixes up more drivers that would
perhaps appear modular when looking at the code, but are controlled by
a bool Kconfig. We make sure they don't look modular and get rid
of module related code in the drivers that would never be used.

The one common thread here for all the patches is that we also
scrap the .remove functions which would only be used for module
unload (impossible) and driver unbind. For the drivers here, there
doesn't seem to be a sensible unbind use case (vs. e.g. a multiport
PCI ethernet driver where one port is unbound and passed through to
a kvm guest or similar). Hence we just explicitly disallow any
driver unbind operations to help prevent root from doing something
illogical to the machine that they could have done previously.

We've already done this for drivers/tty/serial/mpsc.c previously.

Build tested for allmodconfig on ARM64 and powerpc for tty/tty-testing.

Paul.

---

Cc: Andy Gross <agross@xxxxxxxxxxxxxx>
Cc: Anton Blanchard <anton@xxxxxxxxx>
Cc: David Brown <davidb@xxxxxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Jiri Slaby <jslaby@xxxxxxxx>
Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-arm-msm@xxxxxxxxxxxxxxx
Cc: linux-mediatek@xxxxxxxxxxxxxxxxxxx
Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
Cc: linux-serial@xxxxxxxxxxxxxxx
Cc: linux-soc@xxxxxxxxxxxxxxx

Paul Gortmaker (5):
drivers/tty: make hvc/hvc_vio.c explicitly non-modular
drivers/tty: make ehv_bytechan.c explicitly non-modular
drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular
drivers/tty/serial: make msm_serial.c explicitly non-modular
drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular

drivers/tty/ehv_bytechan.c | 40 +++------------------------------
drivers/tty/hvc/hvc_vio.c | 29 ++++--------------------
drivers/tty/serial/8250/8250_mtk.c | 35 ++++++-----------------------
drivers/tty/serial/atmel_serial.c | 45 ++++----------------------------------
drivers/tty/serial/msm_serial.c | 30 ++++---------------------
5 files changed, 22 insertions(+), 157 deletions(-)

--
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/