Re: [PATCH V2 1/4] PM / OPP: Improve debug print messages with pr_fmt

From: Stephen Boyd
Date: Fri Oct 16 2015 - 15:20:38 EST


On 10/16, Viresh Kumar wrote:
> On 15-10-15, 12:04, Stephen Boyd wrote:
> > On 10/15, Viresh Kumar wrote:
> > > With debug options on, it is difficult to locate OPP core's debug
> > > prints. Fix this by prefixing OPP debug prints with KBUILD_MODNAME.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> >
> > Why not use dynamic debug's m flag to turn on KBUILD_MODNAME when
> > debugging?
> >
> > >From Documentation/dynamic-debug-howto.txt
> >
> > m Include module name in the printed message
>
> It wasn't just about debug messages but pr_info and pr_err as well.
> And so I defined pr_fmt instead.
>

Ok, well the commit text exclusively mentions debug, leading me
to believe this is all about making the debug prints (i.e.
pr_debug) have KBUILD_MODNAME.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/