Re: [PATCH] spi: Setup the master controller driver before setting the chipselect

[Mark Brown]

On Thu, Oct 15, 2015 at 03:51:45PM -0500, Franklin S Cooper Jr wrote:
> Some devices depend on the master controller driver setup function being
> called before calling any chipselect functions.
> 
> Insure that this is done otherwise uninitialized structures may be
> accessed causing a kernel panic.

I think this is a sensible change but can we please have a better
changelog - why is this the best thing to do rather than fixing the
driver to not crash?  There are a bunch of good reasons to do the master
setup before asserting chip select but a driver crashing isn't one of
them, it's not clear that this isn't a bug in the driver.

Attachment: signature.asc
Description: PGP signature