Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

From: David Miller
Date: Tue Sep 15 2015 - 15:49:39 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Wed, 09 Sep 2015 17:40:56 -0700

> The code around the allocation and loops are a bit obfuscated.
>
> Neaten it by using:
>
> o kcalloc with decimal count and sizeof(u32)
> o Decimal loop indexing and i++ not i += 4
> o A promiscuous block using a similar style
> to the multicast block
> o Remove unnecessary variables
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/