Re: [PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference

[Trevor Woerner]

On 09/14/15 18:41, green@xxxxxxxxxxxxxx wrote:
> Reviewed-on: http://review.whamcloud.com/14605

I'm confused why the patch found in this email doesn't match the patch I
find when I click on the above link? Some of the patches in this series
match what I find on your jenkins URLs, and some do not.

For example, the function call in the body of the "if" below is
"sysfs_remove_link()" but the function call in the "if" body of the code
I find at http://review.whamcloud.com/14605 after clicking on the
"lustre/lmv/lmv_obd.c" link is "lprocfs_remove_proc_entry()".

Maybe I'm not using your jenkins correctly?

> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6517
> Reviewed-by: James Simmons <uja.ornl@xxxxxxxxx>
> Reviewed-by: John L. Hammond <john.hammond@xxxxxxxxx>
> Reviewed-by: Dmitry Eremin <dmitry.eremin@xxxxxxxxx>
> Signed-off-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 0fc0b61..cebbacf 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -593,11 +593,11 @@ static int lmv_disconnect_mdc(struct obd_device *obd, struct lmv_tgt_desc *tgt)
>  		mdc_obd->obd_force = obd->obd_force;
>  		mdc_obd->obd_fail = obd->obd_fail;
>  		mdc_obd->obd_no_recov = obd->obd_no_recov;
> -	}
>  
> -	if (lmv->lmv_tgts_kobj)
> -		sysfs_remove_link(lmv->lmv_tgts_kobj,
> -				  mdc_obd->obd_name);
> +		if (lmv->lmv_tgts_kobj)
> +			sysfs_remove_link(lmv->lmv_tgts_kobj,
> +					  mdc_obd->obd_name);
> +	}
>  
>  	rc = obd_fid_fini(tgt->ltd_exp->exp_obd);
>  	if (rc)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/