Re: [PATCH] logfs: fix build warning

From: Sudip Mukherjee
Date: Tue Sep 15 2015 - 04:03:32 EST


On Thu, Sep 10, 2015 at 03:41:04PM +0530, Sudip Mukherjee wrote:
> While building we were getting build warning of:
>
> fs/logfs/dev_bdev.c: In function '__bdev_writeseg':
> include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> (void) (&_min1 == &_min2); \
> fs/logfs/dev_bdev.c:84:14: note: in expansion of macro 'min'
> max_pages = min(nr_pages, BIO_MAX_PAGES);
>
> fs/logfs/dev_bdev.c: In function 'do_erase':
> include/linux/kernel.h:601:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> (void) (&_min1 == &_min2); \
> fs/logfs/dev_bdev.c:174:14: note: in expansion of macro 'min'
> max_pages = min(nr_pages, BIO_MAX_PAGES);
>
> Lets use min_t and mention the type.
>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
Hi,
I know its too early to ping. But I can still see the build warnings
with i386 allmodconfig. Build is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/80365417

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/