Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

From: Pravin Shelar
Date: Mon Sep 14 2015 - 19:54:01 EST


On Mon, Sep 14, 2015 at 11:14 AM, Joe Stringer <joestringer@xxxxxxxxxx> wrote:
> Static code analysis reveals the following bug:
>
> net/openvswitch/conntrack.c:281 ovs_ct_helper()
> warn: unsigned 'protoff' is never less than zero.
>
> This signedness bug breaks error handling for IPv6 extension headers when
> using conntrack helpers. Fix the error by using a local signed variable.
>
> Fixes: cae3a2627520: "openvswitch: Allow attaching helpers to ct
> action"
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Joe Stringer <joestringer@xxxxxxxxxx>

Acked-by: Pravin B Shelar <pshelar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/