Re: [PATCH RFC v3 1/6] exterr: Introduce extended syscall error reporting

[Jonathan Corbet]

One more little thing:

> +int ext_err_copy_to_user(void __user *buf, size_t size)
> +{

[...]

> +        ret = copy_to_user(buf, output, len + 1);
> +
> +        kfree(output);
> +
> +	if (!ret)
> +		current->ext_err_code = 0;
> +
> +	return ret ? ret : len + 1;
> +}

I'm pretty sure you really want something like:

	return ret ? -EFAULT : (len + 1);

here.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/