Re: [PATCH v4 04/52] PCI: Optimize bus min_align/size calculation during sizing

From: Yinghai Lu
Date: Mon Sep 14 2015 - 17:37:34 EST


On Mon, Sep 14, 2015 at 1:21 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> I spent a couple hours trying to understand the v3 version of this
> patch, and I gave you some detailed examples and questions. If you
> want me to look at v4, I expect you to try to clarify the changelog to
> help answer those questions.

you example is addressed in following patch that support alt_size

and this patch only handle min_align searching for size is not equal to
align.

>
> The goal is that someone with reasonable familiarity with Linux and
> PCI would be able to read the changelogs and understand what happened,
> without having to search out all the email discussions.

Agreed. But changelog for this should not talk alt_size support in
following patch.

Also please let me know if you prefer to reviewing v5 that would be
re-based on v4.3-rc1
instead of v4. or I could wait to post v5 after you finish v4.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/