Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

From: Jason Gunthorpe
Date: Mon Sep 14 2015 - 13:35:32 EST


On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote:
> The command buffer address is necessarily not naturally aligned.
> The hardware drops the entire read on some platforms and fills the
> address with 1's. This patch fixes the issue by splitting the read
> into two 32 bit reads.

Is this necessary? The packed attribution means that unaligned members
are allowed and the compiler deals with it where necessary.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/