Re: [PATCH] x86: Wire up 32-bit direct socket calls

From: Ingo Molnar
Date: Mon Sep 14 2015 - 09:35:13 EST



* Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:

> On Fri, Sep 11, 2015 at 3:14 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Friday 11 September 2015 11:54:50 Geert Uytterhoeven wrote:
> >> To make sure I don't miss any (it seems I missed recvmmsg and sendmmsg for
> >> the socketcall case, sigh), this is the list of ipc syscalls to implement?
> >>
> >> sys_msgget
> >> sys_msgctl
> >> sys_msgrcv
> >> sys_msgsnd
> >> sys_semget
> >> sys_semctl
> >> sys_semtimedop
> >> sys_shmget
> >> sys_shmctl
> >> sys_shmat
> >> sys_shmdt
> >>
> >> sys_semop() seems to be unneeded because it can be implemented using
> >> sys_semtimedop()?
> >>
> >
> > Yes, that list looks right. IPC also includes a set of six sys_mq_*
> > call, but I believe that everyone already has those as they are not
> > covered by sys_ipc.
> >
> > For y2038 compatibility, we will likely add a new variant of
> > semtimedop that takes a 64-bit timespec. While the argument passed
> > there is a relative time that will never need to be longer than 68
> > years, we need to accommodate user space that defines timespec
> > in a sane way, and converting the argument in libc would be awkward.
> >
>
> I missed sys_ipc entirely.
>
> Ingo, Thomas, want to just wire those up, too? I can send a patch
> next week, but it'll be as trivial as the socket one.

Yeah, sure - split out system calls are so much better (and slightly faster) than
omnibus demuxers.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/