Re: [PATCH 00/15] [v4] x86, fpu: XSAVE cleanups and sanity checks

From: Ingo Molnar
Date: Mon Sep 14 2015 - 06:07:45 EST



* Dave Hansen <dave@xxxxxxxx> wrote:

> Changes in v4:
> * Fix up a few compile errors/warnings
>
> Changes in v3:
> * rework XSTATE_* macros using Ingo's suggested naming
> * change state size printk to be in decimal
> * add some more sanity-checking to detect and work around
> an undersized 'xregs_state'
> * remove "nr_" from some of the names used.
>
> Changes in v2:
> * remove references to Processor Trace XSAVE state
> (will defer to another patch set)
> * Remove some cruft from last patch
> * move last_good_offset fix in to the patch that
> introduced it
>
> These patches make some updates to the x86 XSAVE code.
>
> They have been build and boot tested including on hardware
> and/or simulators with AVX-512 and MPX. It boots in all
> of the tested configurations without hitting any of the
> new warnings in this code. I even added the Memory
> Protecion Keys (the xfeature after MPX) patches on top of
> this and everything works fine.
>
> There are basically 5 things going on here:
> * removal of the LWP (lightweight profiling) code
> * naming and type cleanups
> * removal of xfeatures_nr variable
> * addition of AVX-512 C structures
> * new sanity checks of XSAVE buffer sizing

Ok, very nice! I've applied your series to tip:x86/fpu and will push it out unless
testing finds any problems.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/