Re: [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code

[Wu, Songjun]

On 9/11/2015 18:34, Mark Brown wrote:
> On Thu, Sep 10, 2015 at 10:31:04AM +0800, Wu, Songjun wrote:
> > On 9/9/2015 17:52, Mark Brown wrote:
>
> > > Yes, that's what's going to end up happening but it's not how controls
> > > are expected to behave - applications will expect changing one control
> > > to leave others unaffected so it's better to return an error rather than
> > > change the other control.
>
> > If application change non EQ controls, the others will be unaffected. But
> > the classD IP can only supports one EQ control at once, these three EQ
> > controls point to the same register field, if application set a different EQ
> > control, the error occurs, there will be many errors, it's not very
> > reasonable to application. The best way I think is if application set one EQ
> > control, the other EQ controls will change to 0dB, it's also consistent with
> > fact.
>
> There's no really good solutions here - this is why my initial
> suggestion was to have a single enumerated control.
You are right, your suggestion is reasonable, to have a single 
enumerated control. The second version will be made and sent soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/