Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.

From: Steven Rostedt
Date: Fri Sep 11 2015 - 09:49:50 EST


On Fri, 11 Sep 2015 17:05:31 +0800
Sean Fu <fxinrong@xxxxxxxxx> wrote:


> > Sounds like a reasonable compromise. Sean, can you make a patch that
> > only affects the one proc file (comment it well in the code), and have
> > it accept nothing past the '\0'. Even if someone passed in "1 \0 2", it
> > would only see "1 "

> The current code uses uniform handler (e.g. "proc_dointvec") for all
> same type proc file.
> So all integer type proc file are affected.
> In fact, The behavior of all integer type proc file should be changed.


Then at least make it where the \0 is the terminating string. Nothing
after it will be seen by the rest of the code in the kernel.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/