Re: cpufreq: mediatek: allow modular build

From: Russell King - ARM Linux
Date: Fri Sep 11 2015 - 05:58:34 EST


On Fri, Sep 11, 2015 at 03:10:03PM +0530, Viresh Kumar wrote:
> On 11-09-15, 10:34, Russell King - ARM Linux wrote:
> > Well, that's got nothing to do with not having a module_exit().
>
> Yeah, so we don't necessarily need a module_exit(), but the module
> should have freed the resources with module unplug. And that was
> missing with Arnd's patch..

Not module "unplug" (I've never heard it called that before). A module
with a module_init() but no module_exit() can only be added to a running
kernel, and never removed. That's intentional behaviour.

However, if you're talking about hot-unplug, presumably you're talking
about _CPU_ hot-unplug, and that's something the code should definitely
handle irrespective of whether it's built-in or a module.

The two issues are entirely separate.

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/