Re: [RFC 3/5] acpi/serial: add DBG2 earlycon support

[Mark Rutland]

> > > +#ifdef CONFIG_SERIAL_EARLYCON
> > > +static int use_earlycon __initdata;
> > > +static int __init setup_acpi_earlycon(char *buf)
> > > +{
> > > +	if (!buf)
> > > +		use_earlycon = 1;
> > > +
> > > +	return 0;
> > > +}
> > > +early_param("earlycon", setup_acpi_earlycon);
> > 
> > It seems a shame to add this after folding the OF case into the earlycon
> > code. What necessitates this being a separate early_param? Why is it too
> > early to parse DBG2?
> 
> Currently, we don't even know where our ACPI tables are  at this point
> (efi_init() is called two functions after parse_early_param() in
> setup_arch). More specifically, because acpi_boot_table_init() is
> called even later than that.
> 
> If we moved both of those earlier, we could drop the extra earlycon
> param handling for ACPI. That would of course reduce the ability to
> have dynamically configurable debug messages for both of these.

Ok. Would you be able to put something in the commit message regarding
the above, to make it clear why we need this multi-step dance (and why
it's preferable to the alternative)?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/