Re: [PATCH 3/5] perf tools: Propagate error info for the tracepoint parsing

From: Jiri Olsa
Date: Wed Sep 09 2015 - 03:51:09 EST


On Tue, Sep 08, 2015 at 05:42:25PM -0400, Raphaël Beamonte wrote:

SNIP

> > @@ -386,7 +386,7 @@ PE_NAME ':' PE_NAME
> > struct list_head *list;
> >
> > ALLOC_LIST(list);
> > - if (parse_events_add_tracepoint(list, &data->idx, $1, $3)) {
> > + if (parse_events_add_tracepoint(list, &data->idx, $1, $3, data->error)) {
> > struct parse_events_error *error = data->error;
> >
> > if (error) {
> > --
> > 2.4.3
> >
>
> Works for me.
> Reviewed-by: Raphaël Beamonte <raphael.beamonte@xxxxxxxxx>
>
> I also made sure I could compile and run perf with that patch applied
> on top of the current linux master. Should I also propose my
> Tested-by: tag? I didn't do thorough tests though.

I always base my changes over Arnaldo's perf/core,
which gets eventually merged to Ingo's tip tree and
then the Linus'es tree.. it should be enough to test
it over my branch

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/