Re: [PATCH] zram: don't copy invalid compression algorithms

[Sergey Senozhatsky]

dammit, not going to waste my time on this BS anymore.



> > --- a/drivers/block/zram/zram_drv.c
> > +++ b/drivers/block/zram/zram_drv.c
> > @@ -365,6 +365,9 @@ static ssize_t comp_algorithm_store(struct device *dev,
> >  	struct zram *zram = dev_to_zram(dev);
> >  	size_t sz;
> >  
> > +	if (!zcomp_available_algorithm(buf))
> > +		return -EINVAL;
> 
> If you ignore tailling space, your change would make a bug.
> If you fix it, it looks good to me.

that's why find_backend() calls sysfs_streq(), which takes care of
a trailing new line. unless you're speaking about something else.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/