RE: [PATCH RESEND] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write

From: Chao Yu
Date: Tue Sep 08 2015 - 07:48:06 EST


> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@xxxxxxxxx]
> Sent: Sunday, September 06, 2015 8:29 PM
> To: jaegeuk@xxxxxxxxxx
> Cc: cm224.lee@xxxxxxxxxxx; chao2.yu@xxxxxxxxxxx; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH RESEND] f2fs:Fix incorrect return statement in the function
> f2fs_ioc_release_volatile_write
>
> This fixes the incorrect return statement at the end of the function
> f2fs_ioc_release_volatile_write's body for returning zero as this is
> incorrect due to the function call before this return statement to
> the function punch_hole being able to fail and we should return this
> function's return fail directly in order to signal to callers of the
> function f2fs_ioc_release_volatile if a failure arises with this call
> to punch_hole fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>

Reviewed-by: Chao Yu <chao2.yu@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/