Re: [PATCH 12/15] tools lib api: Add configured support for fs

From: Jiri Olsa
Date: Wed Sep 02 2015 - 09:46:34 EST


On Wed, Sep 02, 2015 at 10:39:31AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 02, 2015 at 09:56:42AM +0200, Jiri Olsa escreveu:
> > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)
> > interface that returns bool state of the filesystem mount:
> > true - mounted, false - not mounted
>
> Well, why not take the opportunity and call it... name__mounted()?
> "__configured()" is too vague...

I mirrored the debugfs/tracefs object interface
we can have another patch changing that

>
> Also there was some cut'n'pasting mistake here... if you agree I can fix
> it all up and make this change, well, I'm doing it on my local tree,
> holler if you have any objection :)
>
> - Arnaldo
>
> > It will not try to mount the filesystem.
>
> No FSTYPE__configured() (to-be FSTYPE__mounted()) doesn't mount
> anything, that is what FSTYPE__mount() does :-)

I stated it just to be clear ;-)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/