Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

[Vladimir Barinov]

Hi Lars,

On 31.08.2015 17:57, Lars-Peter Clausen wrote:
> On 08/17/2015 02:45 PM, Vladimir Barinov wrote:
> > Hello Daniel,
> >
> > I've verified that your hrtimer trigger works.
> >
> > I have minor suggestions.
> >
> > Will not it be useful to have ability to stop/start hrtimer polling
> > not only during attach/detach trigger.
> >
> > f.e. writing 0 to sampling_frequency will hrtimer_cancel
> > and writing any valid frequency will hrtimer_start.
> What's the use case for this?
Setting sampling frequency to 0 Hz.

I do agree that 0Hz is meaningless and the same effect
is achieved by removing trigger from iio device,
but having 0 Hz frequency could probably be more consecutive
for this trigger instead of returning EINVAL.

Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/