Re: [PATCH] tracepoint: don't make assumptions about length of string on task rename

From: Steven Rostedt
Date: Tue Sep 01 2015 - 11:32:42 EST


On Tue, 01 Sep 2015 11:07:32 -0400
Sasha Levin <sasha.levin@xxxxxxxxxx> wrote:


> > Also, as the memcpy was just faster than a strcpy, the static length
> > was used. Perhaps we should convert that to a dynamic length string.
> > But that should be a separate patch as this one fixes a possible bug,
> > and the conversion to a dynamic string is just an enhancement.
>
> That'll slow things down for the common case, no?

Not really that much.

The comms should have been dynamic strings too, but the sched_switch
tracepoint (the one others have been copied from) was created before we
had dynamic strings for tracepoints.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/