Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

[Stephane Eranian]

On Fri, Aug 28, 2015 at 7:39 AM, Liang, Kan <kan.liang@xxxxxxxxx> wrote:
>
> >
> > Em Fri, Aug 28, 2015 at 01:33:22PM +0000, Liang, Kan escreveu:
> > > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.liang@xxxxxxxxx wrote:
> > > > > From: Kan Liang <kan.liang@xxxxxxxxx> print_aggr fails to print
> > > > > per-core/per-socket statistics after commit 582ec0829b3d ("perf
> > > > > stat: Fix per-socket output bug for uncore
> > > > > events") if events have differnt cpus. Because in print_aggr,
> > > > > aggr_get_id needs index (not cpu id) to find core/pkg id. Also,
> > > > > evsel cpu maps should be used to get aggregated id.
> > > > > Signed-off-by: Kan Liang <kan.liang@xxxxxxxxx>
> >
> > > > Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> >
> > > Hi Arnaldo,
> >
> > > Could you please merge this patch?
> > > This patch is to fix a bug of perf stat. It doesn't depend on other
> > > patches of the patchset, and can be merged by itself.
> >
> > Right, in such cases, please, make it clear against which branch this should
> > be applied, i.e. if this is a longstanding bug that needs to go to perf/urgent,
> > i.e. to the current merge window, ASAP, or if this is for something that was
> > introduced in the current development branch, perf/core.
> >
> > In this case it needs to go to perf/urgent, where it applies cleanly,
> > perf/core has extra stuff there that fuzzes a bit.
> >
> > Also, since you know the cset where this bug was introduced, please
> > consider adding a "Fixes:" tag, commom everywhere in the kernel:
>
> OK. I think this patch needs to go to perf/urgent.
> Should I re-send this patch with "Fixes:" tag and comments?
>
Acked-by: Stephane Eranian <eranian@xxxxxxxxxx>

>
> Thanks,
> Kan
> >
> >   [acme@zoo linux]$ git log | grep '^[ \t]\+Fixes:'  | wc -l
> >   3805
> >
> > And we use it in tools/, sometime I add it while editing changelogs, like in
> > this patch:
> >
> >   [acme@zoo linux]$ git log tools/ | grep '^[ \t]\+Fixes:' | head -5
> >     Fixes: 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore
> > events")
> >     Fixes: b685ac22b436 ("perf symbols: Add front end cache for DSO symbol
> > lookup")
> >     Fixes: 06b234ec26fd ("perf script: Don't assume evsel position of tracking
> > events")
> >     Fixes: d4957633bf9d ("perf report: Add infrastructure for a cycles
> > histogram")
> >     Fixes: 75186a9b09e4 ("perf probe: Fix to show lines of sys_ functions
> > correctly")
> >   [acme@zoo linux]$
> >
> > - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/