Re: [RESEND PATCH] mmc: core: fix race condition in mmc_wait_data_done

[Shawn Lin]

å 2015/8/28 18:22, Jialing Fu åé:
> [...]
>
> > > > Hi, ulf
> > > >
> > > > We find this bug on Intel-C3230RK platform for very small probability.
> > > >
> > > > Whereas I can easily reproduce this case if I add a mdelay(1) or
> > > > longer delay as Jialing did.
> > > >
> > > > This patch seems useful to me. Should we push it forward? :)
> > >
> > >
> > > It seems like a very good idea!
> > >
> > > Should we add a fixes tag to it?
> >
> >
> > That's cool, but how to add a fixes tag?
> >
> > [Fixes] mmc: core: fix race condition in mmc_wait_data_done ?   :)
>
> A fixes tag points to an old commit which introduced the bug. If we can't find one, we can add a Cc tag to "stable". Just search the git log and you will find examples.
>
> Like add one line as below?
> Fixes: 2220eedfd7ae ("mmc: fix async request mechanism for sequential read scenarios")

That's it, Jialing. From my git blame, seems this bug has been 
introduced for a long time, but I feel strange that no one had captured 
it before you did.

Anyway, I will add a fixes tag and send v2 ASAP. :)

> Kind regards
> Uffe


--
Best Regards
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/