Re: [PATCH 1/2] mm/page_alloc: change sysctl_lower_zone_reserve_ratio to sysctl_lowmem_reserve_ratio

From: Michal Hocko
Date: Tue Aug 25 2015 - 11:28:31 EST


On Tue 25-08-15 22:01:30, Yaowei Bai wrote:
> We use sysctl_lowmem_reserve_ratio rather than sysctl_lower_zone_reserve_ratio to
> determine how aggressive the kernel is in defending lowmem from the possibility of
> being captured into pinned user memory. To avoid misleading, correct it in some
> comments.

We never had a sysctl like that AFAICS in git history.

> Signed-off-by: Yaowei Bai <bywxiaobai@xxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>

> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0a0acdb..b730f7d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6043,7 +6043,7 @@ void __init page_alloc_init(void)
> }
>
> /*
> - * calculate_totalreserve_pages - called when sysctl_lower_zone_reserve_ratio
> + * calculate_totalreserve_pages - called when sysctl_lowmem_reserve_ratio
> * or min_free_kbytes changes.
> */
> static void calculate_totalreserve_pages(void)
> @@ -6087,7 +6087,7 @@ static void calculate_totalreserve_pages(void)
>
> /*
> * setup_per_zone_lowmem_reserve - called whenever
> - * sysctl_lower_zone_reserve_ratio changes. Ensures that each zone
> + * sysctl_lowmem_reserve_ratio changes. Ensures that each zone
> * has a correct pages reserved value, so an adequate number of
> * pages are left in the zone after a successful __alloc_pages().
> */
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/