Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

From: Tejun Heo
Date: Mon Aug 24 2015 - 18:54:04 EST


Hello, Dave.

On Tue, Aug 25, 2015 at 08:27:20AM +1000, Dave Chinner wrote:
> > I'm still a bit confused. What prevents the following from happening?
> >
> > 1. io completion of last dirty page of an inode and work item for
> > xfs_setfilesize() is queued.
> >
> > 2. inode removed from dirty list.
>
> The inode has already been removed from the dirty list - that
> happens at inode writeback submission time, not IO completion.

Ah, yeah, right, somehow was thinking requeue_io() was being called
from completion path. That's where I was confused.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/