Re: [PATCH] staging: fbtft: Removed space before parenthesis

From: Sudip Mukherjee
Date: Mon Aug 24 2015 - 09:06:27 EST


On Fri, Aug 21, 2015 at 09:05:47PM +0530, Aparna Karuthodi wrote:
> Removed space before parenthesis in two different lines to remove coding
> style errors detected by checkpatch.
> The errors are given below:
> drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before
> that close parenthesis ')'
> drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before
> that close parenthesis ')'
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@xxxxxxxxx>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index b3cddb0..791fab3 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...) \
> } \
> EXPORT_SYMBOL(func);
>
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
> define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
Did you build test it?
You have removed ',' while removing the space and that breaks the build.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/