Re: [PATCH v2] kthread: Export kthread functions

[Neil Horman]

On Thu, Jul 30, 2015 at 11:48:17AM +0800, yalin wang wrote:
> 
> > On Jul 29, 2015, at 18:34, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > 
> > On Tue, 28 Jul 2015, Andrew Morton wrote:
> > 
> >> On Tue, 28 Jul 2015 11:59:01 -0400 David Kershner <david.kershner@xxxxxxxxxx> wrote:
> >> 
> >>> The s-Par visornic driver, currently in staging, processes a queue
> >>> being serviced by the an s-Par service partition. We can get a message
> >>> that something has happened with the Service Partition, when that
> >>> happens, we must not access the channel until we get a message that the
> >>> service partition is back again.
> >>> 
> >>> The visornic driver has a thread for processing the channel, when we
> >>> get the message, we need to be able to park the thread and then resume
> >>> it when the problem clears.
> >>> 
> >>> We can do this with kthread_park and unpark but they are not exported
> >>> from the kernel, this patch exports the needed functions.
> >>> 
> >>> Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx>
> >> 
> >> Please accumulate the acked-by's and reviewed-by's in the changelog as
> >> they are received.   I presently have
> >> 
> >> Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>
> >> Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> >> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >> Cc: Richard Weinberger <richard.weinberger@xxxxxxxxx>
> >> Cc: Tejun Heo <tj@xxxxxxxxxx>
> >> 
> >> 
> >> I'll scoot this into mainline probably this week to make life simpler
> >> for the various trees.
> > 
> i am curious why not make some tiny functions to be inline ?
> so that donât need EXPORT_SYMOBLS , shrink the kernel size.
> Thanks

Because exporting symbols isn't a big deal, and the compiler can decide when its
best to inline these functions.  As it is, they aren't that small, if you expand
all their internals

Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/