Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs.

[NeilBrown]

On Mon, 23 Mar 2015 13:14:50 +0100 jake42
<jake42@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> Hello Neil,
> 
> some suggestions:
> 
> On 23.03.2015 00:20, NeilBrown wrote:
> > From: NeilBrown <neilb@xxxxxxx>
> > diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030
> > b/Documentation/ABI/testing/sysfs-class-power-twl4030
> > new file mode 100644
> > index 000000000000..06092209d851
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030
> > @@ -0,0 +1,15 @@
> > +What: /sys/class/power_supply/twl4030_ac/max_current
> > +      /sys/class/power_supply/twl4030_usb/max_current
> > +Description:
> > +	Read/Write limit on current which which may
> one less which                        ^^
> > +	be drawn from the ac (Accessory Charger) or
> > +	USB port.
> > +
> > +	Value is in micro-Amps.
> > +
> > +	Value is set automatically to an appropriate
> > +	value when a cable is plugged on unplugged.
> s/on/or                               ^^
> > +
> > +	Value can the set by writing to the attribute.
>                    ^^ be set?
> > +	The change will only persist until the next
> > +	plug event.  These event are reported via udev.
> 
> Regards
> Jake
> 

Thanks.
I've made those two changes.

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/