Re: [RFC PATCH 06/14] kthread: Add kthread_worker_created()

[Petr Mladek]

On Tue 2015-07-28 13:26:57, Tejun Heo wrote:
> Hello,
> 
> On Tue, Jul 28, 2015 at 04:39:23PM +0200, Petr Mladek wrote:
> > I would like to make cleaner kthread worker API and hide the definition
> > of struct kthread_worker. It will prevent any custom hacks and make
> > the API more secure.
> > 
> > This patch provides an API to check if the worker has been created
> > and hides the implementation details.
> 
> Maybe it'd be a better idea to make create_kthread_worker() allocate
> and return pointer to struct kthread_worker?  You're adding
> create/destroy interface anyway, it won't need a separate created
> query function and the synchronization rules would be self-evident.

Makes sense. I actually did it this way in one temporary version and reverted
it from some ugly reason.

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/