Re: [PATCH v2 1/4] toshiba_acpi: Change *available functions return type

From: Darren Hart
Date: Wed Jul 29 2015 - 01:03:08 EST


On Mon, Jul 27, 2015 at 07:22:25PM -0600, Azael Avalos wrote:
> This patch changes the *available functions return type from int to
> void.
>
> The checks for support of their respective features are done inside
> such functions and there was no need to return anything as we can
> flag the queried feature as supported inside these functions.
>
> The code was adapted accordingly to these changes and two new
> variables were created and another was changed from uint to bool.
>
> While at the neighborhood, some of the functions were cleaned from

Please consider this a red flag in the future. "While in the neighborhood" means
you need to split the patch across distinct functional boundaries.

--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/