Re: [RFC PATCH perf/core v2 00/16] perf-probe --cache and SDT support

[Arnaldo Carvalho de Melo]

Em Tue, Jul 28, 2015 at 09:42:59AM +0900, Masami Hiramatsu escreveu:
> On 2015/07/28 0:16, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jul 27, 2015 at 11:03:20PM +0900, Namhyung Kim escreveu:
> >> IMHO @ looks perfect for pathnames but I don't know about build-id as
> >> it can be thought as some address.  Anyway I still think @ is a good
> >> choice though. ;-)

> > Yeah, perhaps we need further clarification? I.e. something like:

> > 	sdt_foo:bar:libfoo1.so@buildid(0x1234)

> > Or something else, perhaps shorter, that clarifies that it is a buildid?
> 
> Hmm, Do we really need such additional buildid? Even though, I think

"or something else, perhaps shorter" :-)

> the build id should have different delimiter, like '%', as below.
> 
> sdt_foo:bar@xxxxxxxxxx%buildid

How about:

	sdt_foo:bar@xxxxxxxxxx(0x1234)

Which is clear, to humans: "hey, I want the SDT event 'bar' at the
'libfoo1' library, but make sure it is the one which contents have build
id '0x1234'".

But even the name of the library is not strictly needed, would be just a
nicety for humans, as the way buildids are looked up are by means of:

[acme@zoo tuna]$ ls -la /usr/lib/debug/.build-id/ | tail -5
drwxr-xr-x.   2 root root 4096 Jul 23 09:26 fb/
drwxr-xr-x.   2 root root 4096 Jun 22 19:35 fc/
drwxr-xr-x.   2 root root 4096 Jun 22 19:35 fd/
drwxr-xr-x.   2 root root 4096 Jun 22 19:35 fe/
drwxr-xr-x.   2 root root 4096 Jun 26 16:57 ff/
[acme@zoo tuna]$

So, having:

	sdt_foo:bar@0x1234

Should be unambiguous and shorter.

- ARnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/