RE: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support

[Chen Bough]

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: Monday, July 27, 2015 10:13 PM
> To: Chen Haibo-B51421
> Cc: robh+dt@xxxxxxxxxx; pawel.moll@xxxxxxx; mark.rutland@xxxxxxx;
> ijc+devicetree@xxxxxxxxxxxxxx; galak@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; dmitry.torokhov@xxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; sbranden@xxxxxxxxxxxx; arnd@xxxxxxxx;
> mchehab@xxxxxxxxxxxxxxx; christian.gmeiner@xxxxxxxxx;
> scott.liu@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; hdegoede@xxxxxxxxxx;
> jonathar@xxxxxxxxxxxx; benjamin.tissoires@xxxxxxxxxx;
> hans.verkuil@xxxxxxxxx; hadess@xxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx;
> geert@xxxxxxxxxxxxxx; sebastien.szymanski@xxxxxxxxxxxx;
> mamlinav@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support
> 
> On Mon, Jul 27, 2015 at 07:26:47PM +0800, Haibo Chen wrote:
> > Add touch screen surpport for i.MX6UL-EVK board.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/imx6ul-14x14-evk.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > index 61b41ee..323d32d 100644
> > --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > @@ -44,6 +44,15 @@
> >  	soc-supply = <&reg_soc>;
> >  };
> >
> > +&tsc {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_tsc>;
> > +	status = "okay";
> 
> We generally have "status" at the bottom of the property list.
> 
> Shawn
>
 
[haibo] Yes, it's my negligence, I will amend this.

> > +	xnur-gpio = <&gpio1 3 0>;
> > +	measure_delay_time = <0xffff>;
> > +	pre_charge_time = <0xfff>;
> > +};
> > +
> >  &uart1 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_uart1>;
> > @@ -212,6 +221,15 @@
> >  		>;
> >  	};
> >
> > +	pinctrl_tsc: tscgrp {
> > +		fsl,pins = <
> > +			MX6UL_PAD_GPIO1_IO01__GPIO1_IO01		0xb0
> > +			MX6UL_PAD_GPIO1_IO02__GPIO1_IO02		0xb0
> > +			MX6UL_PAD_GPIO1_IO03__GPIO1_IO03		0xb0
> > +			MX6UL_PAD_GPIO1_IO04__GPIO1_IO04		0xb0
> > +		>;
> > +	};
> > +
> >  	pinctrl_uart1: uart1grp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_UART1_TX_DATA__UART1_DCE_TX 0x1b0b1
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/