Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

From: Christoph Hellwig
Date: Sat Jul 25 2015 - 02:48:56 EST


On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote:
> We've already been through this discussion a couple of years back when
> target_submit_cmd() first came into existence.
>
> The reason iscsi/iser-target continues to be a special case is due to
> immediate data vs. non immediate data and their respective command
> sequence number ordering requirements.

I don't see how immediate data plays into this, the write_pending
callbacks can simply skip the data transfer path, similar to what
Bart's port of the latest SRP target to lio does as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/