Re: [PATCH 1/5] staging: rtl8712: fix buggy size calculation

From: Dan Carpenter
Date: Fri Jul 24 2015 - 06:53:01 EST


On Thu, Jul 23, 2015 at 09:38:33PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by: Joshua Clayton <stillcompiling@xxxxxxxxx>

Looks like you are right.

Reviewed-by: Dan Carpenter

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/