Re: [PATCH 3/7] locking/pvqspinlock: Implement wait-early for overcommitted guest

From: Davidlohr Bueso
Date: Mon Jul 13 2015 - 15:50:34 EST


On Sat, 2015-07-11 at 16:36 -0400, Waiman Long wrote:
> /*
> + * Queued Spinlock Spin Thresholds
> + * -------------------------------
> + * Because of the cacheline contention effect of the ticket spinlock, the
> + * same spin threshold for queued spinlock will run a bit faster. So we set
> + * a slight larger threshold for the queue head (1.25X) while the other queue
> + * nodes will keep the same threshold.

How did you come to 1.25x? These sort of magic numbers scare me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/