Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile

From: Christoph Hellwig
Date: Mon Jul 13 2015 - 02:33:48 EST


On Sun, Jul 12, 2015 at 11:47:32AM +0900, Sergey Senozhatsky wrote:
> Yes, but the main difference here is that it seems that shrinker users
> don't tend to treat shrinker registration failures as fatal errors and
> just continue with shrinker functionality disabled. And it makes sense.
>
> (copy paste from https://lkml.org/lkml/2015/7/9/751)
>

I hearily disagree. It's not any less critical than other failures.

The right way forward is to handle register failure properly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/