[PATCH -mm] parse_integer: add checkpatch.pl notice

From: Alexey Dobriyan
Date: Fri Jul 10 2015 - 17:18:18 EST


* remove check for strict_strto*(), they were fully removed long ago,

* add check for simple_strto*(), suggest replacements

sscanf() is a bit icky to suggest because it accepts arbitrary amount
of whitespace before any integer conversion, but assume programmer
knows such twist and don't use sscanf() where real strictness is
required (yes, sure...).

Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
---

scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5498,10 +5498,10 @@ sub process {
"consider using a completion\n" . $herecurr);
}

-# recommend kstrto* over simple_strto* and strict_strto*
- if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
+# simple_strto*() is deprecated
+ if ($line =~ /\b(simple_strto(l|ll|ul|ull))\s*\(/) {
WARN("CONSIDER_KSTRTO",
- "$1 is obsolete, use k$3 instead\n" . $herecurr);
+ "$1 is obsolete, use parse_integer(), kstrto*(), kstrto*_from_user(), sscanf() instead\n" . $herecurr);
}

# check for __initcall(), use device_initcall() explicitly or more appropriate function please
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/