Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

From: Scott Wood
Date: Fri Jul 10 2015 - 14:50:55 EST


On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote:
> > return in_be32((void *)bm + offset);
> > > ^
> > > [...]/drivers/soc/fsl/qbman/bman.c: In function â__bm_outâ:
> > > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration
> > > of function âout_be32â [-Werror=implicit-function-declaration]
> > > out_be32((void *)bm + offset, val);
> >
> > These PPCisms will need to be fixed. LS1043A is an ARM chip with DPAA
> > 1.0.
>
> LS1043 (ARM, Little Endian) support is still work in progress. The patches
> for that are being tested now but are based on the SDK version of the
> driver and will need to be massaged in order to get them applied here. Our
> plan of record is to add upstream support for this at a later time.

If you're already reworking this for upstream acceptance, why not fix the
more obvious PPCisms now?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/