RE: ACPI: regression: Failed to initialize GIC IRQ controller

From: Moore, Robert
Date: Fri Jul 10 2015 - 10:45:48 EST


It's nice that someone took a sizeof() on the struct -- so, one would hope that no code actually depended on a particular value, no?


> -----Original Message-----
> From: Ming Lei [mailto:ming.lei@xxxxxxxxxxxxx]
> Sent: Friday, July 10, 2015 7:43 AM
> To: Moore, Robert
> Cc: Zheng, Lv; Wysocki, Rafael J; Linux Kernel Mailing List; linux-arm-
> kernel; Thomas Gleixner; Jason Cooper; Hanjun Guo
> Subject: Re: ACPI: regression: Failed to initialize GIC IRQ controller
>
> On Fri, Jul 10, 2015 at 10:28 PM, Moore, Robert <robert.moore@xxxxxxxxx>
> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ming Lei [mailto:ming.lei@xxxxxxxxxxxxx]
> >> Sent: Friday, July 10, 2015 12:46 AM
> >> To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J
> >> Cc: Linux Kernel Mailing List; linux-arm-kernel; Thomas Gleixner;
> >> Jason Cooper; Hanjun Guo
> >> Subject: ACPI: regression: Failed to initialize GIC IRQ controller
> >>
> >> Hi,
> >>
> >> Commit 0cff8dc0099f6d4f(ACPICA: ACPI 6.0: Add changes for MADT
> >> table.) causes the following failure on APM mustang board(arm64) when
> >> booting via UEFI and ACPI:
> >
> >
> > I would be interested to know just what exactly about this change broke
> things.
>
> sizeof(struct acpi_madt_generic_interrupt)
N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ 0¶ìå